elafros/eventing API to to describe the v1beta2 Flow API #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI: to help me better learn the code structure I'll take over this task. |
|
@eobrain my understanding was that the binding work was going to be moved to a sub-directory. Please remove that change from this PR and just add the Flow CRD definition. I'll work with @vaikas-google on a directory structure that makes sense for where we are. |
|
Note I just created a new PR |
|
I'm closing this PR. We're going to go ahead with #18 instead. |
nachocano
pushed a commit
to nachocano/eventing
that referenced
this pull request
Feb 25, 2019
Merge upstream/master.
creydr
pushed a commit
to creydr/knative-eventing
that referenced
this pull request
Jan 25, 2023
The workflows should be removed in the same way as in create-release-branch.sh so that they're not executed when pushing to release-next and release-next-ci branches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue # #14
Proposed Changes
Note, this code compiles and
bazel run :everything.applyexecutes. But a few key parts of the runtime code have been commented out, so nothing actually gets deployed to the Kubernetes cluster.