Fix nil-pointer panic on reportError

[embano1]

If result is nil due to Unwrap() or when passed to reportError, the code
would panic on err.Error().

Fixes: #4378

Signed-off-by: Michael Gasch mgasch@vmware.com

Proposed Changes

Release Note

Docs

[google-cla]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[knative-prow-robot]

Welcome @embano1! It looks like this is your first PR to knative/eventing 🎉

[knative-prow-robot]

Hi @embano1. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

Merging #4391 into master will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #4391      +/-   ##
==========================================
- Coverage   81.13%   81.12%   -0.02%     
==========================================
  Files         287      287              
  Lines        8032     8033       +1     
==========================================
  Hits         6517     6517              
- Misses       1128     1129       +1     
  Partials      387      387              

Impacted Files	Coverage Δ
pkg/adapter/v2/cloudevents.go	62.50% <0.00%> (-0.72%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8ba1df...b2049a5. Read the comment docs.

[lionelvillard]

/ok-to-test

[lionelvillard]

/lgtm

[knative-metrics-robot]

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/adapter/v2/cloudevents.go	66.7%	65.8%	-0.9

[vaikas]

Looks like some of the tests failed with:

        send_event.go:63: Failed to send event Validation: valid
            Context Attributes,
              specversion: 1.0
              type: type1
              source: source1
              id: 3d0cbe40-4ebf-4e39-8df1-27ae9a82da5b
              datacontenttype: application/json
            Data (binary),
              {
                "msg": "e2e-eventtransformation-body"
              }

[vaikas]

@thisisnotapril Any ideas what's going on here wrt CLA?

[vaikas]

Looks like all the e2e tests failed with something like this:

        creation.go:757: Creating pod &Pod{ObjectMeta:{e2e-eventtransformation-sender  test-event-transformation-for-trigger-v1-beta1-broker-v1-cjdxmd    0 0001-01-01 00:00:00 +0000 UTC <nil> <nil> map[] map[] [] []  []},Spec:PodSpec{Volumes:[]Volume{},Containers:[]Container{Container{Name:event-sender,Image:kind.local/event-sender:latest,Command:[],Args:[-sink http://broker-ingress.knative-eventing.svc.c329539220.local/test-event-transformation-for-trigger-v1-beta1-broker-v1-cjdxmd/channel -event {"data_base64":"eyJtc2ciOiJlMmUtZXZlbnR0cmFuc2Zvcm1hdGlvbi1ib2R5In0=","datacontenttype":"application/json","id":"3d0cbe40-4ebf-4e39-8df1-27ae9a82da5b","source":"source1","specversion":"1.0","type":"type1"}],WorkingDir:,Ports:[]ContainerPort{},Env:[]EnvVar{EnvVar{Name:K_CONFIG_TRACING,Value:{"backend":"zipkin","debug":"true","sample-rate":"1","zipkin-endpoint":"http://zipkin.knative-eventing.svc.c329539220.local:9411/api/v2/spans"},ValueFrom:nil,},},Resources:ResourceRequirements{Limits:ResourceList{},Requests:ResourceList{},},VolumeMounts:[]VolumeMount{},LivenessProbe:nil,ReadinessProbe:nil,Lifecycle:nil,TerminationMessagePath:,ImagePullPolicy:IfNotPresent,SecurityContext:nil,Stdin:false,StdinOnce:false,TTY:false,EnvFrom:[]EnvFromSource{},TerminationMessagePolicy:,VolumeDevices:[]VolumeDevice{},StartupProbe:nil,},},RestartPolicy:Never,TerminationGracePeriodSeconds:nil,ActiveDeadlineSeconds:nil,DNSPolicy:,NodeSelector:map[string]string{},ServiceAccountName:,DeprecatedServiceAccount:,NodeName:,HostNetwork:false,HostPID:false,HostIPC:false,SecurityContext:nil,ImagePullSecrets:[]LocalObjectReference{},Hostname:,Subdomain:,Affinity:nil,SchedulerName:,InitContainers:[]Container{},AutomountServiceAccountToken:nil,Tolerations:[]Toleration{},HostAliases:[]HostAlias{},PriorityClassName:,Priority:nil,DNSConfig:nil,ShareProcessNamespace:nil,ReadinessGates:[]PodReadinessGate{},RuntimeClassName:nil,EnableServiceLinks:nil,PreemptionPolicy:nil,Overhead:ResourceList{},TopologySpreadConstraints:[]TopologySpreadConstraint{},EphemeralContainers:[]EphemeralContainer{},},Status:PodStatus{Phase:,Conditions:[]PodCondition{},Message:,Reason:,HostIP:,PodIP:,StartTime:<nil>,ContainerStatuses:[]ContainerStatus{},QOSClass:,InitContainerStatuses:[]ContainerStatus{},NominatedNodeName:,PodIPs:[]PodIP{},EphemeralContainerStatuses:[]ContainerStatus{},},}
        send_event.go:63: Failed to send event Validation: valid
            Context Attributes,
              specversion: 1.0
              type: type1
              source: source1
              id: 3d0cbe40-4ebf-4e39-8df1-27ae9a82da5b
              datacontenttype: application/json
            Data (binary),
              {
                "msg": "e2e-eventtransformation-body"
              }
             to http://broker-ingress.knative-eventing.svc.c329539220.local/test-event-transformation-for-trigger-v1-beta1-broker-v1-cjdxmd/channel: timed out waiting for the condition
            knative.dev/eventing/test/lib.(*Client).SendEvent
            	/home/runner/work/eventing/eventing/src/knative.dev/eventing/test/lib/send_event.go:63
            knative.dev/eventing/test/lib.(*Client).SendEventToAddressable
            	/home/runner/work/eventing/eventing/src/knative.dev/eventing/test/lib/send_event.go:45
            knative.dev/eventing/test/e2e/helpers.EventTransformationForTriggerTestHelper
            	/home/runner/work/eventing/eventing/src/knative.dev/eventing/test/e2e/helpers/broker_event_transformation_test_helper.go:134

@n3wscott

[vaikas]

@n3wscott @slinkydeveloper

[slinkydeveloper]

@vaikas solving the flakyness right now 😄 #4393

[embano1]

@googlebot I signed it!

[n3wscott]

/lgtm
/approve

Thanks!!

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embano1, n3wscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [n3wscott]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment