Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrate the gopath hacks to allow for codegen anywhere #4621

Merged
merged 1 commit into from
Dec 2, 2020

Conversation

n3wscott
Copy link
Contributor

@n3wscott n3wscott commented Dec 2, 2020

Proposed Changes

  • Use GOPATH hacks to codegen anywhere.

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Dec 2, 2020
@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 2, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release labels Dec 2, 2020
@codecov
Copy link

codecov bot commented Dec 2, 2020

Codecov Report

Merging #4621 (85c7f09) into master (e5eee31) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4621   +/-   ##
=======================================
  Coverage   81.31%   81.31%           
=======================================
  Files         290      290           
  Lines        8176     8176           
=======================================
  Hits         6648     6648           
  Misses       1128     1128           
  Partials      400      400           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5eee31...a5a555b. Read the comment docs.

This was referenced Dec 2, 2020
@zhongduo
Copy link
Contributor

zhongduo commented Dec 2, 2020

/lgtm
The complexity is in hack/codegen-library.sh instead of this PR. The fact that all our CI checks run this update-codegen.sh script make me believe it is well tested, as long as all the related PRs pass the tests. (Note that sample-controller does not, but this might be sth else as you said in slack.
/hold
in case you want a second opinion.

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 2, 2020
@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2020
@n3wscott
Copy link
Contributor Author

n3wscott commented Dec 2, 2020

Sample controller now does this: knative-extensions/sample-controller#371 😄

/unhold

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 2, 2020
@knative-prow-robot knative-prow-robot merged commit 1d3519c into knative:master Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants