Add TLS test for sequence #7600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow
bot
added
area/test-and-release
knative-prow
bot
added
the
do-not-merge/hold
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7600 +/- ##
=======================================
Coverage 74.52% 74.52%
=======================================
Files 262 262
Lines 14970 14970
=======================================
Hits 11157 11157
Misses 3223 3223
Partials 590 590 ☔ View full report in Codecov by Sentry. |
creydr
force-pushed
the
add-sequence-tls-test
branch
2 times, most recently
from
2381cc2
to
f98c932
Compare
creydr
force-pushed
the
add-sequence-tls-test
branch
from
1233ee6
to
e7ef268
Compare
knative-prow
bot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
creydr
added a commit
to creydr/knative-eventing
that referenced
this pull request
Jan 19, 2024
* Add TLS test for sequence * Run goimports
knative-prow bot
pushed a commit
that referenced
this pull request
Jan 22, 2024
* Add TLS test for sequence (#7600) * Add TLS test for sequence * Run goimports * Fix TLS support in sequence * Fix intend for CACerts in sequence template provisioning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we're missing a test for the sequences TLS functionality (discussed in todays eventing WG meeting).