Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation for EventPolicy sub suffix matching #8008

Merged

Conversation

pierDipi
Copy link
Member

@pierDipi pierDipi commented Jun 17, 2024

* is only allowed as suffix glob

@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 17, 2024
@knative-prow knative-prow bot requested review from creydr and matzew June 17, 2024 09:46
@pierDipi pierDipi force-pushed the add-validation-for-event-policy-sub branch 4 times, most recently from 4383154 to 842552f Compare June 17, 2024 09:51
@pierDipi pierDipi changed the title Add validation for EventPolicy sub suffix matching Add validation for EventPolicy sub suffix/prefix matching Jun 17, 2024
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.66%. Comparing base (0eee301) to head (2263598).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8008      +/-   ##
==========================================
+ Coverage   67.64%   67.66%   +0.01%     
==========================================
  Files         361      361              
  Lines       16639    16648       +9     
==========================================
+ Hits        11256    11265       +9     
  Misses       4691     4691              
  Partials      692      692              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pierDipi pierDipi changed the title Add validation for EventPolicy sub suffix/prefix matching Add validation for EventPolicy sub suffix matching Jun 17, 2024
@pierDipi pierDipi force-pushed the add-validation-for-event-policy-sub branch from 842552f to d097f8f Compare June 17, 2024 09:54
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi pierDipi force-pushed the add-validation-for-event-policy-sub branch from d097f8f to 2263598 Compare June 17, 2024 09:54
Copy link
Member

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 17, 2024
Copy link

knative-prow bot commented Jun 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 2157639 into knative:main Jun 17, 2024
35 of 37 checks passed
@pierDipi pierDipi deleted the add-validation-for-event-policy-sub branch June 17, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants