Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to Security-Guard 0.6 #1604

Closed
wants to merge 3 commits into from
Closed

Move to Security-Guard 0.6 #1604

wants to merge 3 commits into from

Conversation

davidhadas
Copy link
Contributor

Moved to Security-Guard 0.6

@knative-prow
Copy link

knative-prow bot commented Oct 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidhadas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 19, 2023
@knative-prow
Copy link

knative-prow bot commented Oct 19, 2023

@davidhadas: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
unit-tests_operator_main 037a153 link true /test unit-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@houshengbo
Copy link
Contributor

run ./hack/update-codegen.sh, to update the manifests for security guard.

@davidhadas
Copy link
Contributor Author

./hack/update-codegen.sh

hi @houshengbo,
I already did - what may be the reason that ./hack/update-codegen.sh does not pick up 0.6?

@davidhadas
Copy link
Contributor Author

/hold

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 22, 2023
@davidhadas
Copy link
Contributor Author

/unhold
0.6.1 is released

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 24, 2023
@davidhadas
Copy link
Contributor Author

#1611 seem to resolve this.
Closing..

@davidhadas davidhadas closed this Oct 24, 2023
@davidhadas davidhadas mentioned this pull request Oct 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew Awaiting requested review from matzew

@maximilien maximilien Awaiting requested review from maximilien

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidhadas @houshengbo