Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to Security-Guard 0.6 #1611

Merged
merged 5 commits into from
Oct 24, 2023
Merged

Move to Security-Guard 0.6 #1611

merged 5 commits into from
Oct 24, 2023

Conversation

houshengbo
Copy link
Contributor

@houshengbo houshengbo commented Oct 24, 2023 •
edited by davidhadas
Loading

Bump Security Guard to 0.6

@knative-prow
Copy link

knative-prow bot commented Oct 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 24, 2023
@houshengbo
Copy link
Contributor Author

@davidhadas This is probably need you to change.

@houshengbo
Copy link
Contributor Author

/test eventing-upgrade-tests

@davidhadas davidhadas mentioned this pull request Oct 24, 2023
Closed
@davidhadas davidhadas changed the title Move to Security-Guard 0.6 for the PR 1604 Move to Security-Guard 0.6 Oct 24, 2023
@davidhadas
Copy link
Contributor

@houshengbo ,
I am not sure what you did to reach here, but this includes all changes in #1604 and therefore I am closing #1604 and replacing it with this one.

Thanks.
Are we expected to face a similar issue when we will bump to 0.7? If so, can you describe what was needed to get here?
I.e. can we document here or elsewhere the procedure to bump Security Advisor version in operator?

@davidhadas
Copy link
Contributor

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2023
@knative-prow knative-prow bot merged commit 2b3c9d0 into knative:main Oct 24, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew Awaiting requested review from matzew

@maximilien maximilien Awaiting requested review from maximilien

Assignees

@davidhadas davidhadas

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@houshengbo @davidhadas