Wait for reconciler/controllers to return prior to exiting the sharedmain process #2437
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
size/M
| eg.Go(func() error { | ||
| return controller.StartAll(ctx, controllers...) | ||
| }) |
There was a problem hiding this comment.
note: the other changes are just a minor clean up. Running this in an error group which Waits below is the fix
Codecov Report
@@ Coverage Diff @@
## main #2437 +/- ##
==========================================
+ Coverage 63.49% 63.50% +0.01%
==========================================
Files 228 228
Lines 9996 9991 -5
==========================================
- Hits 6347 6345 -2
+ Misses 3346 3343 -3
Partials 303 303
Continue to review full report at Codecov.
|
|
Looks like eventing keda was using the deprecated method - knative-extensions/eventing-autoscaler-keda#243 |
| for _, controller := range controllers { | ||
| c := controller | ||
| eg.Go(func() error { | ||
| return c.Run(egCtx) |
There was a problem hiding this comment.
can't you run the c.RunContext directly?
There was a problem hiding this comment.
no - errgroup.Go doesn't pass through a ctx to the function - otherwise we could
|
looks good, but tests failing |
|
The failures are known flakes/unrelated - excluding the |
I was just looking at the |
|
I created a PR fix which is linked above |
|
/retest for the flaky knaitve one |
|
/lgtm |
|
/cherry-pick release-1.2 |
|
/cherry-pick release-1.1 |
|
/cherry-pick release-1.0 |
|
/cherry-pick release-0.26 |
|
@dprotaso: new pull request created: #2438 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@dprotaso: new pull request created: #2439 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@dprotaso: new pull request created: #2440 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@dprotaso: new pull request created: #2441 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes: #2436