Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.0] Wait for reconciler/controllers to return prior to exiting the sharedmain process #2440

Merged
merged 1 commit into from
Feb 22, 2022
Merged

[release-1.0] Wait for reconciler/controllers to return prior to exiting the sharedmain process #2440

merged 1 commit into from
Feb 22, 2022

Conversation

knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #2437

@knative-prow-robot knative-prow-robot mentioned this pull request Feb 22, 2022
Merged
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 22, 2022
@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2022
@knative-prow-robot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, knative-prow-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2022
@dprotaso
Copy link
Member

/retest



test/spoof: TestSpoofingClient_WaitForEndpointState/Non_matching_response_triggers_more_requests expand_less | 0s
-- | --
=== RUN   TestSpoofingClient_WaitForEndpointState/Non_matching_response_triggers_more_requests     spoof_test.go:198: Expected Transport to be invoked 3 time but got invoked 2     --- FAIL: TestSpoofingClient_WaitForEndpointState/Non_matching_response_triggers_more_requests (0.00s)

@codecov
Copy link

codecov bot commented Feb 22, 2022 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (release-1.0@96c0204). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             release-1.0    #2440   +/-   ##
==============================================
  Coverage               ?   64.47%           
==============================================
  Files                  ?      226           
  Lines                  ?     9641           
  Branches               ?        0           
==============================================
  Hits                   ?     6216           
  Misses                 ?     3149           
  Partials               ?      276

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96c0204...d0e4cb7. Read the comment docs.

@dprotaso
Copy link
Member

/retest

@knative-prow-robot knative-prow-robot merged commit 929d328 into knative:release-1.0 Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dprotaso dprotaso

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@knative-prow-robot @dprotaso