Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump gomodules.xyz/jsonpatch/v2 from 2.2.0 to 2.3.0 #2789

Merged
merged 3 commits into from
Aug 15, 2023
Merged

Bump gomodules.xyz/jsonpatch/v2 from 2.2.0 to 2.3.0 #2789

merged 3 commits into from
Aug 15, 2023

Conversation

nak3
Copy link
Contributor

@nak3 nak3 commented Aug 14, 2023

This patch replaces #2783
As described in #2783 (comment), upstream changed the logic and some different intermediate patch objects are created.

This patch fixes the unit test.

/kind cleanup

Release Note

NONE

Docs

NONE

@knative-prow knative-prow bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 14, 2023
@codecov
Copy link

codecov bot commented Aug 14, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (6519aff) 81.78% compared to head (223330f) 81.78%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2789   +/-   ##
=======================================
  Coverage   81.78%   81.78%           
=======================================
  Files         167      167           
  Lines       10217    10217           
=======================================
  Hits         8356     8356           
  Misses       1614     1614           
  Partials      247      247

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nak3
Copy link
Contributor Author

nak3 commented Aug 14, 2023

/cc @dependabot @kvmware

Downstream Knative / Unit Test (knative/eventing) is failing but it needs a fix on eventing side as this PR has done.

@knative-prow knative-prow bot requested a review from krsna-m August 14, 2023 07:40
@knative-prow
Copy link

knative-prow bot commented Aug 14, 2023

@nak3: GitHub didn't allow me to request PR reviews from the following users: dependabot.

Note that only knative members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @dependabot @kvmware

Downstream Knative / Unit Test (knative/eventing) is failing but it needs a fix on eventing side as this PR has done.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nak3
Copy link
Contributor Author

nak3 commented Aug 14, 2023

/cc @dprotaso

@knative-prow knative-prow bot requested a review from dprotaso August 14, 2023 07:41
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 14, 2023
@dprotaso
Copy link
Member

@nak3 looks like you'll need to rebase

@dependabot @nak3
Bump gomodules.xyz/jsonpatch/v2 from 2.2.0 to 2.3.0
edef71f 
Bumps [gomodules.xyz/jsonpatch/v2](https://github.com/gomodules/jsonpatch) from 2.2.0 to 2.3.0.
- [Release notes](https://github.com/gomodules/jsonpatch/releases)
- [Changelog](https://github.com/gomodules/jsonpatch/blob/release-2.0/CHANGELOG.md)
- [Commits](gomodules/jsonpatch@v2.2.0...v2.3.0)

---
updated-dependencies:
- dependency-name: gomodules.xyz/jsonpatch/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 15, 2023
@nak3
Copy link
Contributor Author

nak3 commented Aug 15, 2023

Thank you! Rebased.

@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2023
@knative-prow
Copy link

knative-prow bot commented Aug 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, nak3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 15, 2023
@knative-prow knative-prow bot merged commit 4f651e0 into knative:main Aug 15, 2023
35 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsanin-vmw jsanin-vmw Awaiting requested review from jsanin-vmw

@matzew matzew Awaiting requested review from matzew

@krsna-m krsna-m Awaiting requested review from krsna-m

@dprotaso dprotaso Awaiting requested review from dprotaso

Assignees

@dprotaso dprotaso

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nak3 @dprotaso @knative-prow-robot