Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PPC64LE] Added prow job changes for release 1.8 #3590

Merged
merged 1 commit into from
Nov 1, 2022
Merged

[PPC64LE] Added prow job changes for release 1.8 #3590

merged 1 commit into from
Nov 1, 2022

Conversation

mdafsanhossain
Copy link
Contributor

Signed-off-by: mdafsanhossain Mdafsan.Hossain@ibm.com

Which issue(s) this PR fixes:

This PR updates release 1.8 prow jobs for ppc64le

@mdafsanhossain
Added prow job changes for ppc64le release 1.8
37ed57c 
Signed-off-by: mdafsanhossain <Mdafsan.Hossain@ibm.com>
@knative-prow knative-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 28, 2022
@knative-prow
Copy link

knative-prow bot commented Oct 28, 2022

Hi @mdafsanhossain. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 28, 2022
upodroid
upodroid approved these changes Oct 31, 2022
View reviewed changes
Copy link
Member

@upodroid upodroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 31, 2022
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2022
@knative-prow
Copy link

knative-prow bot commented Oct 31, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mdafsanhossain, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2022
@knative-prow knative-prow bot merged commit 3b01cc6 into knative:main Nov 1, 2022
@knative-prow
Copy link

knative-prow bot commented Nov 1, 2022

@mdafsanhossain: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key client-release-1.8.gen.yaml using file prow/jobs/generated/knative/client-release-1.8.gen.yaml
  • key eventing-release-1.8.gen.yaml using file prow/jobs/generated/knative/eventing-release-1.8.gen.yaml
  • key operator-release-1.8.gen.yaml using file prow/jobs/generated/knative/operator-release-1.8.gen.yaml

In response to this:

Signed-off-by: mdafsanhossain Mdafsan.Hossain@ibm.com

Which issue(s) this PR fixes:

This PR updates release 1.8 prow jobs for ppc64le

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mdafsanhossain mdafsanhossain deleted the release-1.8 branch February 1, 2023 06:11
@mdafsanhossain mdafsanhossain mentioned this pull request Feb 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upodroid upodroid upodroid approved these changes

Assignees

@upodroid upodroid

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdafsanhossain @upodroid