Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust release 1.9 jobs for ppc64le #3702

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

mdafsanhossain
Copy link
Contributor

Signed-off-by: mdafsanhossain Mdafsan.Hossain@ibm.com

Which issue(s) this PR fixes:

This PR updates release 1.9 ppc64le jobs

Signed-off-by: mdafsanhossain <Mdafsan.Hossain@ibm.com>
@knative-prow
Copy link

knative-prow bot commented Feb 2, 2023

Hi @mdafsanhossain. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 2, 2023
@krsna-m
Copy link
Contributor

krsna-m commented Feb 4, 2023

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 4, 2023
@krsna-m
Copy link
Contributor

krsna-m commented Feb 7, 2023

@mdafsanhossain Could you please provide justification to the PR?

@mdafsanhossain
Copy link
Contributor Author

@mdafsanhossain Could you please provide justification to the PR?

This PR changes the cron timings for 1.9 ppc64le job configs so that it does not conflict with the timings for the main job configs. It is similar to #3590

@krsna-m
Copy link
Contributor

krsna-m commented Feb 8, 2023

/approve /lgtm

@knative-prow
Copy link

knative-prow bot commented Feb 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kvmware, mdafsanhossain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2023
@krsna-m
Copy link
Contributor

krsna-m commented Feb 8, 2023

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 8, 2023
@knative-prow knative-prow bot merged commit c9cf1d0 into knative:main Feb 8, 2023
@knative-prow
Copy link

knative-prow bot commented Feb 8, 2023

@mdafsanhossain: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key client-release-1.9.gen.yaml using file prow/jobs/generated/knative/client-release-1.9.gen.yaml
  • key eventing-release-1.9.gen.yaml using file prow/jobs/generated/knative/eventing-release-1.9.gen.yaml
  • key operator-release-1.9.gen.yaml using file prow/jobs/generated/knative/operator-release-1.9.gen.yaml
  • key serving-release-1.9.gen.yaml using file prow/jobs/generated/knative/serving-release-1.9.gen.yaml

In response to this:

Signed-off-by: mdafsanhossain Mdafsan.Hossain@ibm.com

Which issue(s) this PR fixes:

This PR updates release 1.9 ppc64le jobs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants