Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Caesar cipher #44

Closed
TheSTL opened this issue Oct 7, 2019 · 4 comments
Closed

Caesar cipher #44

TheSTL opened this issue Oct 7, 2019 · 4 comments
Assignees
@ashokdey @Omkaragrawal
Labels
bug Something isn't working

Comments

@TheSTL
Copy link
Member

TheSTL commented Oct 7, 2019

⚠️ Issue

Caesar cipher should raise and error when second argument is not a number, instead it's returning a string of "undefinedundefinedundefined"
@TheSTL TheSTL added bug Something isn't working Hacktoberfest labels Oct 7, 2019
@ashokdey ashokdey assigned ashokdey and TheSTL and unassigned TheSTL Oct 7, 2019
@ashokdey
Copy link
Member

ashokdey commented Oct 7, 2019

Thanks, @fcosueza, for pointing out this in #40. I am taking up this.

@fcosueza
Copy link

fcosueza commented Oct 7, 2019

You're welcome 😃

@Omkaragrawal
Copy link

Hey,
I would like to take up the task for Caesar Cipher, including testing, etc.

@ashokdey
Copy link
Member

ashokdey commented Oct 8, 2019

Okay, go ahead @Omkaragrawal 👍

@fcosueza fcosueza mentioned this issue Oct 8, 2019
Closed
@Omkaragrawal Omkaragrawal mentioned this issue Oct 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ashokdey ashokdey

@Omkaragrawal Omkaragrawal

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Caesar cipher [Fixed #40] [Fixed #44] Omkaragrawal/problem-solving-javascript
4 participants
@fcosueza @ashokdey @Omkaragrawal @TheSTL