Skip to content

Conversation

Omkaragrawal
Copy link

Fixed #113 added armstrong number.

@Omkaragrawal
Copy link
Author

hey, @TheSTL can you help me with what is the failing check about?

@TheSTL
Copy link
Member

TheSTL commented Oct 23, 2019

By reading this post from stack over flow I think coverage is decreased because some code lines are not covered in test cases. And we can get it by total test cases* code not covered in one test case.
Code not covered in single test case is because of Control Structures.
Example this code num = (!Number.isNaN(Number(num))) ? parseInt(Math.abs(Number(num)), 10).toString() : (() => { throw Error('error')
@ashokdey @Omkaragrawal

@Omkaragrawal
Copy link
Author

Hey,
@TheSTL @ashokdey so is it ok? If not what do I need to do for it, add a case that evaluates the error?

@TheSTL
Copy link
Member

TheSTL commented Oct 24, 2019

@Omkaragrawal I think Armstrong Number should not be tested for decimals. It should throw error for decimal number or any other input except Integer.

  • Remove tests for decimals.
  • Add test cases where it should except to throw error

@Omkaragrawal
Copy link
Author

Hey, there are some minor changes in the test that's it, give me some time since I have my University exams till 28th.

@ashokdey
Copy link
Member

ashokdey commented Nov 1, 2019

Ok.

@ashokdey ashokdey closed this Dec 17, 2019
@ashokdey ashokdey added the dead label Dec 17, 2019
@Omkaragrawal
Copy link
Author

Hey @ashokdey I regret that I totally forgot about this. I will get to this soon and rewrite the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Armstrong No.
3 participants