Skip to content

Sets #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 26, 2020
Merged

Sets #161

merged 4 commits into from
Apr 26, 2020

Conversation

ashokdey
Copy link
Member

@ashokdey ashokdey commented Dec 7, 2019

⛽️ What's Inside?

  • Added implementation of Set data structure
  • APIs are
    • add(el)
    • remove(el)
    • values()
    • has(el)

@ashokdey ashokdey self-assigned this Dec 7, 2019
@ashokdey ashokdey requested a review from TheSTL December 7, 2019 06:52
TheSTL
TheSTL reviewed Dec 18, 2019
View reviewed changes
src/_DataStructures_/Set/index.js
return this.data.val();
}

union(givenSet) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If givenSet is not instanceOf XSet. Then it should throw error.

@ashokdey ashokdey merged commit ec38f2e into master Apr 26, 2020
@ashokdey ashokdey deleted the sets branch September 6, 2020 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheSTL TheSTL TheSTL left review comments

Assignees

@ashokdey ashokdey

Labels
beginner friendly enhancement New feature or request new-data-structure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashokdey @TheSTL