[JS] Support React 19 in React SDKs #419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: e2563d9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
MikeCarbone
changed the title
This was referenced Feb 20, 2025
|
@connorlindsey Re: tanstack-store. Chris and I talked about it but we figured it was out of scope for now. I'm a big tanstack fan, the idea sounds nice! But let's revisit that another time |
MikeCarbone
deleted the
mike-kno-7523-2-js-support-react-19-in-react-sdks
branch
Closed
MikeCarbone
added a commit
that referenced
this pull request
Mar 12, 2025
* [JS] Support React 19 in React SDKs (#419) * removes react-popper dependency * allow react 19 * upgrades zustand * merge * fixes render loop bug * adjusts version number, removes placeholder * undo example changes for this branch * Better URL in comment * fixes zustand implementation * matches types on main * Use new store * merges in examples * Cleanup CRA example * fixes docs to remove zustand requirement * Tests pass locally * fixes dev dependency issues * runs lint * runs format * remove unused dependency * adds setup env variable * clean up PR * Improves selector typing and validates that it works * runs formatter * comment removes unnecessary info * Better import and comments * rips out rerender hack * better styling setup * updates to match main and easier merge * run lint and format * Updates a few readmes * Create red-owls-jog.md * adds version bumps for dependent packages and adds migration guide * adds package specific upgrade guides * updates upgrade guide to be more specific * better formatting on upgrade guide * downgrade zustand to support react 16 * undo manual version bump * update guides and small PR feedback updates * updates docs examples to stick with useNotificationStore * adds links to upgrade guides * fix(kno-7523): fixes separation of zustand vanilla and react (#429) * fixes type handling * testing new behavior * lint and format * Removes upgrade guide and validated store * remove console logs * removes test data * fix(kno-7971): adds autoRegister to useEffect deps (#437) * fix(kno-7523): fixes bad returns from useNotificationStore (#439) * fix(kno-7523): fixes bad returns from useNotificationStore * adds better types and comments: * fixes hook name * adds tests * bumps telegraph component versions in nextjs example * align turbo * lock eslint-config-turbo resolution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[JS] Support React 19 in React SDKs
Breaking changes:
feed.storenow uses theUseBoundStore<StoreApi<FeedStoreState>>type (previouslyStoreApi<FeedStoreState>), meaning users no longer need their own implementation ofzustandto use the store directly.Users who relied only on
useNotificationStoreto access the store will not be affected, only users who usefeedClient.storedirectly.General Changes:
Enables support for React 19
This PR adds support for React 19 by including it within the
peerDependenciesof the various packages.Removes
react-popperdependencyThis dependency was deprecated. I opted to use our existing dependency
@popperjs/corefor popup elementsUpgrades
zustandto v4Introduces a breaking change when users use the
feedClient.storedirectly.We decided not to upgrade to
v5because that would drop support for React 16, which we should support.Upgrades internal
Telegraphcomponents for React 19 supportIn order for these packages to support React 19, we had to first enable our Telegraph components to support React 19. After that was done, I bumped all of the Telegraph dependencies in this PR.
Next.js Example Now Uses Telegraph Components
Now that we have the
@telegraphdesign system supporting React 19, we were able to use it in thenext-js-exampleapp.A note on
react-nativepackage:As of 2 days ago, React 19 is now available on React Native, however, dependent packages like react-shallow-renderer need time to catch up and support this. So for now, we will leave the
react-nativepackage as is. This causes a dependency warning when runningyarn installat the root of this repository, but that won't affect individual builds.Linear issue
Addresses issue "Support React 19 #317"