chore(KNO-8961): remove withReadonlyField option #549
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
mattmikolay
changed the title
mattmikolay
requested review from
connorlindsey and
thomaswhyyou
and removed request for
connorlindsey
| opts: ReadLayoutDirOpts = {}, | ||
| ): Promise<ParseJsonResult | JoinExtractedFilesResult> => { | ||
| const { abspath } = layoutDirCtx; | ||
| const { withExtractedFiles = false, withReadonlyField = false } = opts; |
There was a problem hiding this comment.
It appears we never set withReadonlyField to true anywhere within the codebase.
It's been awhile so I'm trying to remember (😅) but I think I provided these options for completeness early on, to mirror the annotation directive which controls how a resource payload gets transformed and written into a json file.
And conceptually these "read" functions do the inverse, so I probably thought having options to control how the read behavior works with respect to extractable and readonly fields made sense. But it turned out the commands we have (so far at least) that reads from the file system haven't necessarily needed to care about the read only fields .
mattmikolay
deleted the
mattmik-kno-8961-cli-remove-withreadonlyfield-option-from-directory-read
branch
3 participants
Description
This PR removes the
withReadonlyFieldoption from the various functions used to read resource directories. It appears we never setwithReadonlyFieldtotrueanywhere within the codebase.Tasks
KNO-8961