Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set layer media types consistently #776

Merged
merged 2 commits into from
Jul 21, 2022
Merged

Conversation

imjasonh
Copy link
Member

We currently always append layers with Docker media types, even if the base image is an OCI image (e.g., our new default base image, ghcr.io/distroless/static)

This works fine against some registries (GCR), but not against others (apparently Quay, Gitlab Registry, probably others).

This was reported in tektoncd/pipeline#5188 since Tekton switched its base image for git-init to ghcr.io/distroless/git

This changes our layer creation to check for the type of the base image, and set layer media types accordingly.

@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2022

Codecov Report

Merging #776 (ea7d482) into main (d32cfff) will increase coverage by 0.10%.
The diff coverage is 82.35%.

@@            Coverage Diff             @@
##             main     #776      +/-   ##
==========================================
+ Coverage   51.20%   51.30%   +0.10%     
==========================================
  Files          44       44              
  Lines        3316     3329      +13     
==========================================
+ Hits         1698     1708      +10     
- Misses       1401     1403       +2     
- Partials      217      218       +1     
Impacted Files Coverage Δ
pkg/build/gobuild.go 59.13% <82.35%> (+0.29%) ⬆️

@imjasonh imjasonh added this to the 0.12 milestone Jul 21, 2022
@imjasonh imjasonh merged commit 2f230b8 into ko-build:main Jul 21, 2022
@imjasonh imjasonh mentioned this pull request Jul 22, 2022
khrm added a commit to tektoncd/triggers that referenced this pull request Sep 6, 2022
We updated ko to v0.12.0 so that media layers are set consistently.
Reference issue: ko-build/ko#776
@khrm khrm mentioned this pull request Sep 6, 2022
4 tasks
tekton-robot pushed a commit to tektoncd/triggers that referenced this pull request Sep 6, 2022
We updated ko to v0.12.0 so that media layers are set consistently.
Reference issue: ko-build/ko#776
khrm added a commit to khrm/pipeline that referenced this pull request Sep 22, 2022
This ko version fixes ko-build/ko#776 which should resolve
tektoncd#5188
@khrm khrm mentioned this pull request Sep 22, 2022
7 tasks
tekton-robot pushed a commit to tektoncd/pipeline that referenced this pull request Sep 23, 2022
This ko version fixes ko-build/ko#776 which should resolve
#5188
tekton-robot pushed a commit to tekton-robot/pipeline that referenced this pull request Sep 28, 2022
This ko version fixes ko-build/ko#776 which should resolve
tektoncd#5188
tekton-robot pushed a commit to tektoncd/pipeline that referenced this pull request Sep 28, 2022
This ko version fixes ko-build/ko#776 which should resolve
#5188
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants