ci: build and test using 1.18 and 1.19 (drop 1.17) #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #812 +/- ##
==========================================
- Coverage 51.40% 51.37% -0.03%
==========================================
Files 44 44
Lines 3354 3354
==========================================
- Hits 1724 1723 -1
Misses 1408 1408
- Partials 222 223 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mattmoor
approved these changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
k8s apimachinery now seems to require 1.18: #804
Since 1.19 came out last month, 1.17 is no longer officially supported.
This PR also removes the Go 1.18 compat e2e test,
which should also let us remove some pre-1.18 compat code in a future PR.edit: just went ahead and removed the pre-1.18 code.