-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to configure default platforms #897
Conversation
@imjasonh something like this? Unfortunately there is no easy way to test this properly without either
WDYT? |
This looks great! This is honestly even less code than I thought it would be. 👍 The test seems fine. Maybe worth adding another |
fa1c902
to
c486001
Compare
I added another test case but not with splitting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, that test covers exactly what I was hoping to find out!
Codecov Report
@@ Coverage Diff @@
## main #897 +/- ##
==========================================
+ Coverage 51.33% 51.34% +0.01%
==========================================
Files 44 44
Lines 3407 3414 +7
==========================================
+ Hits 1749 1753 +4
- Misses 1430 1432 +2
- Partials 228 229 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Seems like there was already an empty line in that file which is not really visible in GitHub. |
2b46068
to
ab8e3c1
Compare
Thanks again for this contribution, and for fighting through the lint checks for it! 😅 |
Adds an option to configure default platforms either in
.ko.yaml
or using the env variableKO_DEFAULTPLATFORMS
.Fixes #521