Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update debug package to version 4.0.0 #1243

Closed
ryanelian opened this issue Sep 11, 2018 · 4 comments · Fixed by #1245
Closed

Update debug package to version 4.0.0 #1243

ryanelian opened this issue Sep 11, 2018 · 4 comments · Fixed by #1245

Comments

@ryanelian
Copy link

I am getting warnings in my CI due to updated debug package:

warning webpack-serve > koa > debug@3.2.4: `debug` versions 3.2.0-3.2.2 break Node 4. Users of node LTS and onward (modern Node versions): please upgrade to `debug@4` or above as soon as possible. Node 4 users: please pin to `debug@>=3.2.3 <4` as it will be the last version range that supports Node@4.

The debug project recommends a package update to version 4.0.0 to mitigate vulnerabilities and performance improvement.

@fengmk2
Copy link
Member

fengmk2 commented Sep 11, 2018

v1.x is already fixed on #1241, please reinstall and it will be fixed now.

@fengmk2 fengmk2 closed this as completed Sep 11, 2018
@fengmk2 fengmk2 reopened this Sep 11, 2018
@fengmk2
Copy link
Member

fengmk2 commented Sep 11, 2018

https://github.com/koajs/koa/blob/master/package.json#L30 koa master need to update

@ryanelian
Copy link
Author

ryanelian commented Sep 11, 2018

v1.x is already fixed on #1241, please reinstall and it will be fixed now.

https://github.com/koajs/koa/pull/1241/files#diff-b9cfc7f2cdf78a7f4b91a753d10865a2R28

3.2.4 is what causing the deprecation warning. I doubt that change will remove the warning message. Perhaps pin the package to exact 3.1.0?

@fengmk2
Copy link
Member

fengmk2 commented Sep 11, 2018

@ryanelian I'm going to pin debug@2 on koa@1 and debug@~3.1.0 on koa@2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants