Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox extensions #23

Closed
koba04 opened this issue Sep 9, 2021 · 9 comments · Fixed by #33
Closed

Firefox extensions #23

koba04 opened this issue Sep 9, 2021 · 9 comments · Fixed by #33
Labels
enhancement New feature or request

Comments

@koba04
Copy link
Owner

koba04 commented Sep 9, 2021

No description provided.

@koba04 koba04 added the enhancement New feature or request label Sep 9, 2021
@jellydn
Copy link
Contributor

jellydn commented Oct 6, 2021

Hi @koba04

Do you have any plan for working on this item yet? If not, I would take a try to implement this one. My plan is using this one https://github.com/antfu/vitesse-webext Thanks.

@koba04
Copy link
Owner Author

koba04 commented Oct 6, 2021

@jellydn Thank you! I don't have any plan for this yet. I have a question. vitesse-webext seems to be a starter template for WebExtension and includes full-stack features for WebExtension. Why do we have to use vitesse-webext to support Firefox?

@jellydn
Copy link
Contributor

jellydn commented Oct 6, 2021

Hi @koba04 It's more than a personal choice when I am comparing 'webpack' vs 'vitejs'. Have you tried 'ViteJs' before? I really like their DX. That's why I would suggest the starter.

@jellydn
Copy link
Contributor

jellydn commented Oct 6, 2021

The main logic is using https://github.com/mozilla/webextension-polyfill and replaces 'chrome.' with 'browser.' I think.

@koba04
Copy link
Owner Author

koba04 commented Oct 6, 2021

@jellydn
Yeah, I know vite gives us great DX.
However, I prefer discussing it as another issue because I think using webextension-polyfill is relevant to this issue but using vite is not.

@jellydn
Copy link
Contributor

jellydn commented Oct 6, 2021

Agreed. Thanks. Let me try to draft a PR about it.

@jellydn
Copy link
Contributor

jellydn commented Oct 7, 2021

Hi @koba04 Let me know if you have any feedback on the PR. Thanks.

@koba04
Copy link
Owner Author

koba04 commented Oct 12, 2021

I've published SWRDevTools into the Mozilla's developer hub and am waiting for the review.

@koba04
Copy link
Owner Author

koba04 commented Oct 14, 2021

@jellydn SWRDevTools has been published as a Firefox extension 🚀 🚀 🚀 Thanks @jellydn for your great work!!
https://addons.mozilla.org/en-US/firefox/addon/swr-devtools/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants