Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: support Firefox Extension #29

Merged
merged 10 commits into from
Oct 11, 2021
Merged

Feat: support Firefox Extension #29

merged 10 commits into from
Oct 11, 2021

Conversation

jellydn
Copy link
Contributor

@jellydn jellydn commented Oct 7, 2021

WHAT

WHY

HOW

  • Use runtine/Runtime from "webextension-polyfill" package as discussed.

How to test

yarn build:extensions (build extension)
web-ext run -s=packages/swr-devtools-extensions/dist (need to install web-ext CLI if not)

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Linter
  • Tests
  • Review comments

@vercel
Copy link

vercel bot commented Oct 7, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/koba04/swr-devtools/2nq7jbBH9ex4PexBX7U9c2Cr1Rzn
✅ Preview: https://swr-devtools-git-fork-jellydn-feature-support-firefox-koba04.vercel.app

@koba04 koba04 self-assigned this Oct 8, 2021
koba04
koba04 requested changes Oct 8, 2021
View reviewed changes
Copy link
Owner

@koba04 koba04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jellydn
Thank you for your work!! This is great 👍 👍 👍
Would you check the comments I've left on this PR?

packages/swr-devtools-extensions/CHANGELOG.md Outdated Show resolved Hide resolved
packages/swr-devtools-extensions/manifest.json Outdated Show resolved Hide resolved
packages/swr-devtools-extensions/package.json Outdated Show resolved Hide resolved
packages/swr-devtools-extensions/src/devtools.html Show resolved Hide resolved
packages/swr-devtools-extensions/src/panel.html Outdated Show resolved Hide resolved
@jellydn
Copy link
Contributor Author

jellydn commented Oct 8, 2021

Sure. Let me check. Thanks

jellydn and others added 2 commits October 8, 2021 14:36
@jellydn @koba04
Update packages/swr-devtools-extensions/package.json
2d8b567 
Co-authored-by: Toru Kobayashi <koba0004@gmail.com>
@jellydn @koba04
Update packages/swr-devtools-extensions/manifest.json
71a2f7e 
Co-authored-by: Toru Kobayashi <koba0004@gmail.com>
@jellydn jellydn requested a review from koba04 October 8, 2021 09:08
jellydn
jellydn commented Oct 8, 2021
View reviewed changes
Copy link
Contributor Author

@jellydn jellydn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @koba04 I have cleaned up as your feedback. Let me know if you have anything to improve. Thanks.

@jellydn @koba04
Update packages/swr-devtools-extensions/src/devtools.html
e9057e1 
Co-authored-by: Toru Kobayashi <koba0004@gmail.com>
@jellydn jellydn requested a review from koba04 October 9, 2021 18:41
@koba04 koba04 merged commit 27f5f0e into koba04:main Oct 11, 2021
@koba04
Copy link
Owner

koba04 commented Oct 11, 2021

@jellydn Thank you for your great works 👏 👏 I'll publish the Firefox Extension!

@jellydn jellydn deleted the feature/support-firefox branch October 11, 2021 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koba04 koba04 koba04 approved these changes

Assignees

@koba04 koba04

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jellydn @koba04