Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically upgrade from shared to separate dbs #66

Merged
merged 3 commits into from
Jan 13, 2020
Merged

Automatically upgrade from shared to separate dbs #66

merged 3 commits into from
Jan 13, 2020

Conversation

jnm
Copy link
Member

@jnm jnm commented Jan 9, 2020

Closes #65
Depends upon kobotoolbox/kpi#2545

@jnm jnm requested a review from noliveleger January 9, 2020 23:24
noliveleger
noliveleger approved these changes Jan 13, 2020
View reviewed changes
Copy link
Contributor

@noliveleger noliveleger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works perfectly.

I'm wondering whether we should warn the user that the task can task a while with big databases?

@noliveleger noliveleger merged commit d044dce into two-databases Jan 13, 2020
@noliveleger noliveleger deleted the 65-upgrade-to-separate-databases branch January 13, 2020 15:48
noliveleger
noliveleger reviewed Jan 13, 2020
View reviewed changes
helpers/upgrading.py
from helpers.cli import CLI
from helpers.config import Config

def migrate_single_to_two_databases():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PEP-8 expects 2 blank lines ;-)

@jnm jnm mentioned this pull request Jan 13, 2020
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noliveleger noliveleger noliveleger approved these changes

Assignees

@noliveleger noliveleger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jnm @noliveleger