Fix "There was an error loading Enketo" when attempting to edit submissions #4979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`file` columns in `select_one_from_file` and `select_multiple_from_file` rows. This was causing a `KeyError` when the asset content predated #4403 and kobotoolbox/formpack#314. Flattening of `{"type": "select_one_from_file", "file": "choices.csv"}` (and equivalent `select_multiple_from_file` structures) to the XLSForm-standard `{"type": "select_one_from_file choices.csv"}` is handled by kobotoolbox/formpack#318 and kobotoolbox/formpack#319.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Properly handle surveys that were created with
select_one_from_fileorselect_multiple_from_filequestions prior to release 2.024.09.Notes
Remove brittle and now unnecessary flattening of
filecolumns inselect_one_from_fileandselect_multiple_from_filerows. This was causing aKeyErrorwhen the asset content predated #4403 and kobotoolbox/formpack#314.Flattening of
{"type": "select_one_from_file", "file": "choices.csv"}(and equivalentselect_multiple_from_filestructures) to the XLSForm-standard{"type": "select_one_from_file choices.csv"}is handled by kobotoolbox/formpack#318 and kobotoolbox/formpack#319.Related issues
Fixes a problem in #4403 and kobotoolbox/formpack#314
Related to kobotoolbox/formpack#318 and kobotoolbox/formpack#319