Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4334 loader overflow issue #4344

Merged
merged 1 commit into from
Nov 17, 2022
Merged

#4334 loader overflow issue #4344

merged 1 commit into from
Nov 17, 2022

Conversation

prachi00
Copy link
Member

@prachi00 prachi00 commented Nov 17, 2022

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address:
    Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
    Screen Shot 2022-11-16 at 7 39 11 PM

@prachi00 prachi00 requested a review from a team as a code owner November 17, 2022 03:39
@prachi00 prachi00 requested review from Jarsen136 and removed request for a team November 17, 2022 03:39
@netlify
Copy link

netlify bot commented Nov 17, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 46abc83
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/6375acee987628000837afbb
😎 Deploy Preview https://deploy-preview-4344--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kodabot
Copy link
Collaborator

kodabot commented Nov 17, 2022

SUCCESS @prachi00 PR for issue #4334 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@codeclimate
Copy link

codeclimate bot commented Nov 17, 2022

Code Climate has analyzed commit 46abc83 and detected 0 issues on this pull request.

View more on Code Climate.

@prachi00
Copy link
Member Author

@yangwao @exezbcz so this part wasn't covered in the designs, for now, I have just given it dynamic height so it doesn't break in this case, let me know where to put it design wise

@exezbcz
Copy link
Member

exezbcz commented Nov 17, 2022

@yangwao @exezbcz so this part wasn't covered in the designs, for now, I have just given it dynamic height so it doesn't break in this case, let me know where to put it design wise

Hi! Not sure if i understand the question, can you please rephrase it or add some screenshots?

@yangwao
Copy link
Member

yangwao commented Nov 17, 2022

I guess fair for now :)
pay 20 usd

@yangwao
Copy link
Member

yangwao commented Nov 17, 2022

😍 Perfect, I’ve sent the payout
💵 $20 @ 24.18 USD/KSM ~ 0.827 $KSM
🧗 EzGc4s9PgCPx1YnF3fqzhLzVHpHMTL4LWPScwpDrR8JKgSU
🔗 0xd80a53575b8e118a9ae353c757f69caccf2236e03b396b6a6633e8475ecbdaa2

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Nov 17, 2022
@yangwao
Copy link
Member

yangwao commented Nov 17, 2022

We should top up new fun facts about the KodaDot ecosystem. Maybe ambassadors can help us with this? :)

@yangwao yangwao merged commit 7fc91fc into main Nov 17, 2022
@yangwao yangwao deleted the feat-loader-overflow branch November 17, 2022 14:31
@exezbcz
Copy link
Member

exezbcz commented Nov 17, 2022

Ahh, ic what you mean. Okay, then we could rephrase it like:
Stuck? - as a heading
the rest will be paragraph

@roiLeo roiLeo mentioned this pull request Nov 23, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scrolled text in the mint popup
4 participants