GitHub Page

Hello @kelvinlauKL,

Is there any chance that you can public GitHub Page's link in the repository's description?

Thanks,

[kelvinlauKL]

Open up a PR and I'll gladly add it in! @aquarchitect!

@kelvinlauKL, I am thinking of adding the link, http://raywenderlich.github.io/swift-algorithm-club/, right to the repository's description like the screenshot I attached below.

Let me know what you think. If it is not possible, I can add the link to the README file in a PR.

[kelvinlauKL]

@aquarchitect I just checked out the link in Mojave dark mode, and I see this:

I'm going to hold off adding that link on there. Would you know how to handle this?

@kelvinlauKL I got no idea. The script relies on GitHub rendering engine to convert README to HTML. I don't have Mojave installed to test out myself, but do you have any trouble of viewing a readme document from GitHub site on Mojave?

[kelvinlauKL]

@aquarchitect The README is fine, but the generated html is behaving badly on Mojave.

Hi @kelvinlauKL,

Can you view this link https://aquarchitect.github.io/swift-algorithm-club/ if you still have the issue of dark background on Mojave? If it's good to go, I will create a PR.

Thanks.

[kelvinlauKL]

Roger. I'm at work on a non-Mojave computer, so I'll take a look once I get home. Thanks!

Hi @kelvinlauKL,

The issue of dark mode has been resolved itself in the official release of Mojave, and it requires no further action.

However, regards to the original issue, I still would love to have the link to GitHub Page version of the repo publicly available under the description (please prefer to my previous comment). It is a much nicer and better experience for everyone to enjoy these wonderful articles.

Thank you so much for considering my proposal.

[kelvinlauKL]

Hey @aquarchitect, I took another look at the GitHub page and it doesn't seem to be much of an improvement to the README files.

For now I've added a reference to it to the README!