Skip to content

Conversation

jftung
Copy link
Contributor

@jftung jftung commented Apr 10, 2016

I am part of a group of four people. Our final project for one of our classes is to contribute to an open source project. We would like to work on this repository! We will be working on several data structures and algorithms, and we'd like to claim some now. Note that we will probably "claim" a few others later, depending on availability.

Currently "claimed" projects:
Trie
Radix Sort
Radix Tree
Red Black Tree
Threaded Binary Tree

@hollance
Copy link
Member

Looking good!

Note that counting sort is also being worked on by #103

@jftung
Copy link
Contributor Author

jftung commented Apr 28, 2016

We've had to cut a few of the data structures due to time constraints (updated in my original comment), but our project is due May 6, so expect us to be done by then!

@jftung
Copy link
Contributor Author

jftung commented May 6, 2016

We should be ready for you to look over our work! I know that we're missing Playgrounds and unit tests, but I hope that our contribution is helpful in some way. Let us know what's good, what's bad, and what we can do to make your life easier.

@axptwig
Copy link
Contributor

axptwig commented May 6, 2016

I'm still working on Red Black Trees, i need to fix a bug delete and make the implementation adhere to the style guide

@Thukor
Copy link
Contributor

Thukor commented May 6, 2016

I won't be able to provide test files tonight, but as of now there should only be minor bugs (if any) in the implementation for Trie (assuming I didn't mess up big time somewhere).

@hollance
Copy link
Member

hollance commented May 6, 2016

Starting to look good, guys! :-)

Some small points:

  • Can you rename the folder "Radix-Sort" to "Radix Sort" (drop the -)?
  • Can you rename the folder "Red Black Trees" to "Red-Black Tree" (drop the s and add the -)?
  • The Red-Black Tree seems not to take advantage of Swift's optionals. There's a lot of ! in there. It would be better to use if let to unwrap those, that is more Swift-like.
  • The () are not necessary with if, so instead of if (something) you can simply write if something.
  • Where did you get the images for Red-Black Tree and Threaded Binary Tree from? Did you make these yourself or did you copy them from somewhere? If the latter, please make sure you only use images whose license allows it and include a reference to the original. (We want to avoid any copyright violations.)

Let me know when you're done and I'll do the merge.

@jftung
Copy link
Contributor Author

jftung commented May 6, 2016

The folder names should be good now, and the if parentheses have been removed from all but the Red-Black Tree files. I made the Threaded Binary Tree images using www.draw.io, as mentioned at the bottom of the README. I'm not sure where my partner got the Red-Black tree images from. I'll get back to you.

Ashwin added 2 commits May 6, 2016 16:54
@hollance
Copy link
Member

Quick announcement: this repo is moving to https://github.com/raywenderlich/swift-algorithm-club -- everything should still work as before but some old links may not work anymore.

@jftung
Copy link
Contributor Author

jftung commented May 13, 2016

Quick update, @axptwig is still working on the Red-Black tree fixes, but other than that we should be all set.

@chris-pilcher
Copy link

This looks great! 👍

@jftung @axptwig are you still working on the Red-Black tree fixes? Also, did you find out where the Red-Black images came from?

@jftung
Copy link
Contributor Author

jftung commented Jun 7, 2016

Hi! I've lost contact with @axptwig, but if you want we can separate our different data structures into different forks so you can choose what you want to pull (l can make a new pull request).

@chris-pilcher
Copy link

Thanks for the update @jftung. I can merge this as a single pull request. I will do this tonight.

@chris-pilcher chris-pilcher merged commit 2bc9a0c into kodecocodes:master Jun 8, 2016
chris-pilcher pushed a commit that referenced this pull request Jun 8, 2016
Added links to algorithms submitted in PR #102
@jftung
Copy link
Contributor Author

jftung commented Jun 8, 2016

Excellent, thank you! Let me know if you need anything else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants