Skip to content

Added support to proxy paths. #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 6, 2015
Merged

Added support to proxy paths. #2

merged 1 commit into from
Jul 6, 2015

Conversation

tux-cheeleong
Copy link
Contributor

Minor addition to allow the proxy to pass request path and parameter.

@fatih
Copy link
Contributor

fatih commented Jul 6, 2015

Hi @tuxccl. You know that you can build your own custom proxy with passing the Backend your self. Is there any reason we want it in the default example constructor?

@tux-cheeleong
Copy link
Contributor Author

There are cases where upstream serves multiple paths and take in parameter (example, /hello/world?foo=bar).
But the default behaviors ignores these from the request and assume upstream serving only the root.
Probably it is sufficient in your use case but adding these few lines is enough for a more general use case (it might look hackish because I don't want to change the interface).

@fatih
Copy link
Contributor

fatih commented Jul 6, 2015

Got it, thanks for the reply. I just wanted to be sure :) Merging it, thanks 👍

fatih added a commit that referenced this pull request Jul 6, 2015
Added support to proxy paths.
@fatih fatih merged commit f90542e into koding:master Jul 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants