Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New attempt to close issue #15
Last attempt: #25
This version is significantly less invasive. It still relies on passing a dict of forward references to the Config class, these are then passed to the
globalns
param oftyping.get_type_hints()
, cleaning each type hint of forward refs.The resolved types are injected into the rest of the code by creating a copy of each
dataclass.Field
object in the main loop, and reassigning the.type
attr to the cleaned type.Each new field object then carries forward the correct type to the rest of the logic.
Let me know what you think!