Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite of transformations features #55

Merged
merged 10 commits into from
May 12, 2019
Merged

Conversation

konradhalas
Copy link
Owner

@konradhalas konradhalas commented May 5, 2019

This PR is a result of discussion in #38. It fixes #52 and #53.

Short summary:

  • I removed all dict shape transformations features (flattened, prefixed, remap)
  • I changed semantic of transform - it's "type-based" now, so instead of {field_path: callback}, now you have to provide {field_type: callback} mapping
  • I removed also cast - you can now achieve similar behaviour with new transform (e.g. {str: str})

This PR is in a WIP state because of:

  • missing documentation
  • code review

@konradhalas konradhalas changed the title Rewrite of transformations features WIP: Rewrite of transformations features May 5, 2019
@konradhalas konradhalas self-assigned this May 5, 2019
@konradhalas konradhalas added this to the v1.0.0 milestone May 5, 2019
@konradhalas konradhalas changed the title WIP: Rewrite of transformations features Rewrite of transformations features May 12, 2019
@konradhalas konradhalas merged commit 8f51a8b into master May 12, 2019
@konradhalas konradhalas deleted the feature/config-v1-changes branch January 4, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove all dict shape transformation features
2 participants