-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement importing the function from the statusImpl if it exists, #47
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #47 +/- ##
=========================================
Coverage ? 61.45%
=========================================
Files ? 9
Lines ? 358
Branches ? 85
=========================================
Hits ? 220
Misses ? 137
Partials ? 1 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
2a211ae
to
34aba66
Compare
cfb9879
to
90d8bbf
Compare
ce22c18
to
2bdbb1e
Compare
README.md
Outdated
@@ -126,6 +126,9 @@ The supported commands are divided into groups according to their target, at thi | |||
* `backup --action [backup|restore|clean]` - This command enables you to use [Kontent.ai backup manager](https://github.com/kontent-ai/backup-manager-js) | |||
* The purpose of this tool is to backup & restore [Kontent.ai projects](https://kontent.ai/). This project uses CM API to both get & restore data. | |||
|
|||
* `status --implementation` - This command creates in your working directory a new directory with a file `statusImpl.ts`. Having this file created, CLI will take your custom implementation of saving/reading the migrations status. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure about the name of the file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to add this scaffolding in the implementation as a command?
I would expect to tell them -> hay there is an expected file with this function with this signature. It should be in js (and if you want to use TS set up a transpilation).
…plugins file command update lint
1ca0295
to
a99b07b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for the PR, I'll merge it and release it.
Motivation
Which issue does this fix? Fixes #39
If no issue exists, what is the fix or new feature? Were there any reasons to fix/implement things that are not obvious?
Checklist
How to test
If manual testing is required, what are the steps?