Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement importing the function from the statusImpl if it exists, #47

Merged
merged 14 commits into from
May 4, 2023

Conversation

IvanKiral
Copy link
Contributor

Motivation

Which issue does this fix? Fixes #39

If no issue exists, what is the fix or new feature? Were there any reasons to fix/implement things that are not obvious?

Checklist

  • Code follows coding conventions held in this repo
  • Automated tests have been added
  • Tests are passing
  • Docs have been updated (if applicable)
  • Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

If manual testing is required, what are the steps?

@codecov-commenter
Copy link

codecov-commenter commented Mar 16, 2023

Codecov Report

❗ No coverage uploaded for pull request base (master@ff5ee97). Click here to learn what that means.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff            @@
##             master      #47   +/-   ##
=========================================
  Coverage          ?   61.45%           
=========================================
  Files             ?        9           
  Lines             ?      358           
  Branches          ?       85           
=========================================
  Hits              ?      220           
  Misses            ?      137           
  Partials          ?        1           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@IvanKiral IvanKiral marked this pull request as ready for review April 3, 2023 09:29
README.md Outdated
@@ -126,6 +126,9 @@ The supported commands are divided into groups according to their target, at thi
* `backup --action [backup|restore|clean]` - This command enables you to use [Kontent.ai backup manager](https://github.com/kontent-ai/backup-manager-js)
* The purpose of this tool is to backup & restore [Kontent.ai projects](https://kontent.ai/). This project uses CM API to both get & restore data.

* `status --implementation` - This command creates in your working directory a new directory with a file `statusImpl.ts`. Having this file created, CLI will take your custom implementation of saving/reading the migrations status.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about the name of the file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to add this scaffolding in the implementation as a command?

I would expect to tell them -> hay there is an expected file with this function with this signature. It should be in js (and if you want to use TS set up a transpilation).

Copy link
Contributor

@winklertomas winklertomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the PR, I'll merge it and release it.

@winklertomas winklertomas merged commit 0288dcc into master May 4, 2023
@winklertomas winklertomas deleted the decouple_status branch May 4, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decouple the status information
4 participants