-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Class to plain #10
Merged
Merged
Class to plain #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Works around the "Unknown field ... on type ..." [GraphQL error](gatsbyjs/gatsby#8053). **Note:** Introduces a breaking change. The data of content elements now reside in the `elements` property, not in the root of each `kenticoCloudItem` node.
JanLenoch
pushed a commit
to kontent-ai/gatsby-starter
that referenced
this pull request
Oct 14, 2018
Make the starter work after kontent-ai/gatsby-packages#10 is merged.
JanLenoch
pushed a commit
to kontent-ai/gatsby-starter
that referenced
this pull request
Oct 14, 2018
Make the starter work even after kontent-ai/gatsby-packages#10 is merged.
This was referenced Oct 14, 2018
Simply007
suggested changes
Oct 15, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve comments.
Mind the pull:
#9
whether it make sense to allow pass whole config (because typeresolvers are not used now)
There's no need to adjust the current PR to #9 ATM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #7
Works around the "Unknown field ... on type ..." GraphQL error by submitting plain JavaScript objects to the
createNode
Gatsby API method.Note: Introduces a breaking change. The data of content elements now reside in the
elements
property, not in the root of eachkenticoCloudItem
node. The docu has been updated accordingly.Checklist
How to test
Copy the
gatsby-source-kentico-cloud
folder into theplugins
folder of the starter site. Either use the Babel-built files, or, if debugging in VS is desired, copy the source files fromsrc
into the parent folder temporarily.