Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class to plain #10

Merged
merged 6 commits into from
Oct 15, 2018
Merged

Class to plain #10

merged 6 commits into from
Oct 15, 2018

Conversation

JanLenoch
Copy link
Contributor

@JanLenoch JanLenoch commented Oct 14, 2018

Motivation

Fixes #7

Works around the "Unknown field ... on type ..." GraphQL error by submitting plain JavaScript objects to the createNode Gatsby API method.

Note: Introduces a breaking change. The data of content elements now reside in the elements property, not in the root of each kenticoCloudItem node. The docu has been updated accordingly.

Checklist

  • Code follows coding conventions held in this repo
  • Automated tests have been added
  • Tests are passing
  • Docu has been updated (if applicable)
  • Temporary settings (e.g. project ID used during development and testing) have been reverted to defaults

How to test

Copy the gatsby-source-kentico-cloud folder into the plugins folder of the starter site. Either use the Babel-built files, or, if debugging in VS is desired, copy the source files from src into the parent folder temporarily.

Jan Lenoch added 2 commits October 12, 2018 10:16
Works around the "Unknown field ... on type ..." [GraphQL error](gatsbyjs/gatsby#8053).

**Note:** Introduces a breaking change. The data of content elements now reside in the `elements` property, not in the root of each `kenticoCloudItem` node.
JanLenoch pushed a commit to kontent-ai/gatsby-starter that referenced this pull request Oct 14, 2018
Make the starter work after kontent-ai/gatsby-packages#10 is merged.
JanLenoch pushed a commit to kontent-ai/gatsby-starter that referenced this pull request Oct 14, 2018
Make the starter work even after kontent-ai/gatsby-packages#10 is merged.
Copy link
Contributor

@Simply007 Simply007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve comments.

Mind the pull:
#9

whether it make sense to allow pass whole config (because typeresolvers are not used now)

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@JanLenoch
Copy link
Contributor Author

There's no need to adjust the current PR to #9 ATM.

@JanLenoch JanLenoch merged commit 627fd9d into master Oct 15, 2018
@JanLenoch JanLenoch deleted the class-to-plain branch October 16, 2018 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants