Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add workspaces to Tekton pipeline for git repo creds and registry creds #1045

Merged

Conversation

HarikrishnanBalagopal
Copy link
Contributor

@HarikrishnanBalagopal HarikrishnanBalagopal commented Jun 12, 2023

Also put relative paths in the Tekton pipeline when there is no git repo. This makes the pipeline more usable.

Example:

    - name: build-push-1
      params:
        - name: IMAGE
          value: $(params.image-registry-url)/golang
        - name: DOCKERFILE
          value: '<TODO: fill this prefix starting from the root of the git repo>/golang/Dockerfile'
        - name: CONTEXT
          value: '<TODO: fill this prefix starting from the root of the git repo>/golang'

…ry creds

Also put relative paths in the Tekton pipeline when there is no git repo.
This makes the pipeline more usable.

Signed-off-by: Harikrishnan Balagopal <harikrishmenon@gmail.com>
@github-actions
Copy link

Thanks for making a pull request! 😃
One of the maintainers will review and advise on the next steps.

@github-actions github-actions bot added the feat label Jun 12, 2023
@ashokponkumar ashokponkumar enabled auto-merge (squash) June 12, 2023 09:11
@ashokponkumar ashokponkumar merged commit 883539c into konveyor:main Jun 12, 2023
@HarikrishnanBalagopal HarikrishnanBalagopal deleted the feat/tektonrelpaths branch June 12, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants