Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix FFI cdecls #1619

Merged
merged 5 commits into from
Jul 3, 2023
Merged

fix FFI cdecls #1619

merged 5 commits into from
Jul 3, 2023

Conversation

benoit-pierre
Copy link
Contributor

@benoit-pierre benoit-pierre commented Jun 11, 2023 •
edited by Frenzie
Loading

Nothing major, I just re-run ffi-cdecl to ensure prototypes are up-to-date, and removed some ZLIB related duplicates.

This change is Reviewable

@Frenzie Frenzie requested a review from NiLuJe June 11, 2023 20:22
NiLuJe
NiLuJe reviewed Jun 12, 2023
View reviewed changes
ffi/leptonica_h.lua Outdated Show resolved Hide resolved
@benoit-pierre benoit-pierre mentioned this pull request Jul 3, 2023
Merged
@poire-z
Copy link
Contributor

poire-z commented Jul 3, 2023

@NiLuJe : good for you ?

NiLuJe
NiLuJe approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@NiLuJe NiLuJe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, missed the update, my bad ;).

@poire-z poire-z merged commit cab7ae3 into koreader:master Jul 3, 2023
1 of 2 checks passed
@benoit-pierre benoit-pierre deleted the pr/fix_ffi-cdecls branch July 3, 2023 21:30
benoit-pierre added a commit to benoit-pierre/koreader that referenced this pull request Jul 3, 2023
@benoit-pierre
bump base
42c6a29 
- koreader/koreader-base#1619
- koreader/koreader-base#1623
- koreader/koreader-base#1628
@benoit-pierre benoit-pierre mentioned this pull request Jul 3, 2023
Merged
poire-z pushed a commit to koreader/koreader that referenced this pull request Jul 3, 2023
@benoit-pierre
bump base: libk2pdfopt, fix ffi cdecls, improved ccache (#10638)
4b9de16 
- koreader/koreader-base#1619
- koreader/koreader-base#1623
- koreader/koreader-base#1628
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NiLuJe NiLuJe NiLuJe approved these changes

@Frenzie Frenzie Frenzie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@benoit-pierre @poire-z @NiLuJe @Frenzie