Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make: fix NEON support detection #1784

Merged
merged 1 commit into from
May 13, 2024
Merged

make: fix NEON support detection #1784

merged 1 commit into from
May 13, 2024

Conversation

benoit-pierre
Copy link
Contributor

@benoit-pierre benoit-pierre commented May 13, 2024 •
edited by Frenzie
Loading

NEON support is available when compiling with TARGET=linux LINUX_ARCH=arm64 (-march=armv8-a).

This change is Reviewable

@benoit-pierre
make: fix NEON support detection
a714b30 
NEON support is available when compiling with `TARGET=linux LINUX_ARCH=arm64` (`-march=armv8-a`).
NiLuJe
NiLuJe approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@NiLuJe NiLuJe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, this one slipped through the cracks ;).

@Frenzie Frenzie merged commit 2476d4d into koreader:master May 13, 2024
1 check passed
@benoit-pierre benoit-pierre deleted the pr/fix_neon_support_for_linux_arm64 branch May 13, 2024 17:40
@benoit-pierre benoit-pierre mentioned this pull request May 13, 2024
Merged
Frenzie pushed a commit to koreader/koreader that referenced this pull request May 13, 2024
@benoit-pierre
bump base (#11814)
c9c8089 
- koreader/koreader-base#1782
- koreader/koreader-base#1783
- koreader/koreader-base#1784
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NiLuJe NiLuJe NiLuJe approved these changes

@pazos pazos Awaiting requested review from pazos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benoit-pierre @NiLuJe @Frenzie