Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship openlipclua #1829

Merged
merged 6 commits into from
Jun 24, 2024
Merged

Ship openlipclua #1829

merged 6 commits into from
Jun 24, 2024

Conversation

NiLuJe
Copy link
Member

@NiLuJe NiLuJe commented Jun 20, 2024

For koreader/koreader#12056

Pending notmarek/openlipclua#1 so we actually have a Makefile to use ;p.


This change is Reviewable

@NiLuJe
Copy link
Member Author

NiLuJe commented Jun 20, 2024

First time adding stuff to the revamped buildsystem, hoping I didn't forget anything @benoit-pierre ;).

@NiLuJe NiLuJe marked this pull request as ready for review June 20, 2024 18:11
@NiLuJe NiLuJe merged commit a9e32ff into koreader:master Jun 24, 2024
3 checks passed
@Frenzie
Copy link
Member

Frenzie commented Jun 29, 2024

I just noticed the legacy Kindle build has been failing.

openlipclua.c: In function 'check_lipc_code':
openlipclua.c:25:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
         if (code != -1) {
                  ^~
openlipclua.c: In function 'openlipcluaha_to_table':
openlipclua.c:159:21: error: a label can only be part of a statement and a declaration is not a statement
                     int data;
                     ^~~
openlipclua.c:165:21: error: a label can only be part of a statement and a declaration is not a statement
                     char* data_str;
                     ^~~~
make[2]: *** [Makefile:13: openlipclua.o] Error 1

https://gitlab.com/koreader/nightly-builds/-/jobs/7220477049

@NiLuJe
Copy link
Member Author

NiLuJe commented Jun 30, 2024

Huh. I'll look into it on Monday!

NiLuJe added a commit to NiLuJe/openlipclua that referenced this pull request Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants