Bugfix/fix link checker #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se lychee-action to check all the links in the entire project.
jordens
reviewed
Sep 22, 2022
Add link to lynchee in the changelog Co-authored-by: Robert Jördens <rj@quartiq.de>
There was a problem hiding this comment.
@dzimmanck I'd really like to get these issues resolved so we can keep moving with smlang. This has been blocking a release of one of our crates for quite a while at this point and I'd really prefer to not have to fork smlang just to push out our updates
| uses: peter-evans/create-issue-from-file@v4 | ||
| with: | ||
| title: Link Checker Report | ||
| content-filepath: ./lychee/out.md |
There was a problem hiding this comment.
I think this template file may have been omitted during the checkin?
|
Yeah, I get it. Let me see if I can get things moving. Give me a few days.
…On Fri, Oct 28, 2022, 2:00 AM Ryan Summers ***@***.***> wrote:
***@***.**** commented on this pull request.
@dzimmanck <https://github.com/dzimmanck> I'd really like to get these
issues resolved so we can keep moving with smlang. This has been blocking a
release of one of our crates for quite a while at this point and I'd really
prefer to not have to fork smlang just to push out our updates
------------------------------
In .github/workflows/links.yml
<#46 (comment)>:
> + runs-on: ubuntu-latest
+ steps:
+ - uses: ***@***.***
+
+ - name: Link Checker
+ id: lychee
+ uses: ***@***.***
+ env:
+ GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}}
+
+ - name: Create Issue From File
+ if: steps.lychee.outputs.exit_code != 0
+ uses: ***@***.***
+ with:
+ title: Link Checker Report
+ content-filepath: ./lychee/out.md
I think this template file may have been omitted during the checkin?
—
Reply to this email directly, view it on GitHub
<#46 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD3JLZVM7WDQ2R4FCJQDRUDWFOI23ANCNFSM6AAAAAAQR3H3IE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Yatekii
approved these changes
Oct 28, 2022
|
I've got the power! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.