Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This adds accessors to
Img
'sbuf
member and deprecates direct access to it.I "need" this because I'm using ImgRef as a container to transfer image data to OpenGL, which requires a pointer to the pixels.
This cannot be done efficiently with iterators (technically it can, but it's hacky), and I don't feel comfortable about directly using the
buf
member knowing it will be private someday.In short, it feels like
Img
"steals" the container from me, and I'd like it back :)Thanks in advance :) I acknowledge that this is probably a bit petty and the newly introduced
deprecated
warnings may annoy a bunch of people.