-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Absolute paths to relative #310
Comments
If you follow the link, you'll see I managed some progress :) The current wall I hit is:
|
It seems like I managed to do it! Attached is the diff, in case anyone is interested.
Should I do a PR? |
I have also run into this trying to put kosmtik behind an ingress controller. Would be swell to be able to have relative URLs to assets. Is there any reason NOT to make this the default behavior? |
Yes! Sorry for my very late response.
ERRNOTIME ;) |
There is an addRoute call to what looks like an absolute URL '/hash.js' at the end of hash/index.js which StyXman did not change - and neither will I until and unless testing indicates it is required
Hi. I know this is an unusual request, so if you think it's not reasonable, I can understand.
I'm trying to put kosmtik behind a reverse proxy. The problem is that kosmtik returns absolute paths for all the assets, so even when the main page returns fine, all the assets give 404s. Example:
http://dionecanali.hd.free.fr/praetorian/diablo:6789/osm-carto/#16/43.5842/7.1194
Line 6 already has this:
Would it be possible to make those paths relative? If I knew enough JS/node, I would do it myself in my own instance and not bother the project with this.
The text was updated successfully, but these errors were encountered: