Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll bar added #230

Conversation

Souvik34
Copy link
Contributor

@Souvik34 Souvik34 commented Jan 5, 2024

Scroll bar added

Issue No: #299

Copy link

vercel bot commented Jan 5, 2024

@Souvik34 is attempting to deploy a commit to the kossiitkgp Team on Vercel.

A member of the Team first needs to authorize it.

@Souvik34
Copy link
Contributor Author

Souvik34 commented Jan 5, 2024

Scroll bar added

Copy link

vercel bot commented Jan 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kwoc-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 12, 2024 9:14am

package.json Outdated Show resolved Hide resolved
src/components/Navbar.tsx Outdated Show resolved Hide resolved
src/components/Navbar.tsx Outdated Show resolved Hide resolved
src/components/Navbar.tsx Outdated Show resolved Hide resolved
src/components/Scrollbar.css Outdated Show resolved Hide resolved
@harshkhandeparkar
Copy link
Member

@Souvik34 run pnpm build locally and fix any errors it displays.

src/components/Navbar.tsx Outdated Show resolved Hide resolved
src/components/Navbar.tsx Outdated Show resolved Hide resolved
src/components/Navbar.tsx Outdated Show resolved Hide resolved
@@ -143,7 +144,9 @@ function Navbar() {
}

function MobileNavbar({ toggleMobileMenu }: { toggleMobileMenu: () => void }) {
const [bodyStyle] = useState({});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still there.

@@ -106,6 +106,7 @@ function Navbar() {
};

return (

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And revert these extra changes please.

@harshkhandeparkar
Copy link
Member

@Souvik34 Can you send a screenshot of how the scrollbar is supposed to look? Also check if it works on Firefox (I don't think it is working for me).

@Souvik34
Copy link
Contributor Author

Souvik34 commented Jan 6, 2024

image It is looking like this in Brave image It is looking like this in Edge. image It is looking like this in Chrome.

@harshkhandeparkar
Copy link
Member

It is working on Chromium based browsers. Is it possible to make it work on Firefox?

@Souvik34
Copy link
Contributor Author

Souvik34 commented Jan 6, 2024

Alright I am working for it asap.

@harshkhandeparkar
Copy link
Member

@Souvik34 any update?

@Souvik34
Copy link
Contributor Author

Updated

src/main.css Outdated Show resolved Hide resolved
@harshkhandeparkar
Copy link
Member

Thanks @Souvik34! 🚀

@harshkhandeparkar harshkhandeparkar merged commit 8b97d22 into kossiitkgp:truth-redefined-again Jan 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants