-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The Companion field corresponding to an internal companion object is not part of the public API #53
Comments
Which version of kotlin and this tool are you using? |
Sorry, forgot to specify that. This is with Kotlin 1.4.31 and version 0.2.4 of this plugin. I didn't see anything in the changelog of more recent versions of this plugin that would make me think it's fixed, but I can also try to reproduce with 0.5.0 if you'd like. |
I noticed something similar with Kotlin 1.5.0 and an older version of this tool (so not the exact same issue, but similar), so I wouldn't be surprised if this has been fixed too. |
…e visibility of the companion class itself Fixes #53
…0.8.0 - See: Kotlin/binary-compatibility-validator#53 Signed-off-by: Antal János Monori <antal.monori@transferwise.com>
…0.8.0 - See: Kotlin/binary-compatibility-validator#53 Signed-off-by: Antal János Monori <antal.monori@transferwise.com>
* Update build and compile dependencies - Updated to binary-compatibility-validator 0.8.0 - Updated to Gradle 7.3 - Updated to AGP 7.0.3 Signed-off-by: Antal János Monori <antal.monori@transferwise.com> * Update API contract after a regression with Kotlin 1.5+ got fixed in 0.8.0 - See: Kotlin/binary-compatibility-validator#53 Signed-off-by: Antal János Monori <antal.monori@transferwise.com>
…outer class to th… * Evaluate 'static final Companion' visibility in the outer class to the visibility of the companion class itself Fixes Kotlin/binary-compatibility-validator#53 Pull request Kotlin/binary-compatibility-validator#59
If I have a class declared like:
The API dump is incorrectly showing the
Companion
field as part of the public API:The text was updated successfully, but these errors were encountered: