Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reexport hFlush #315

Closed
wants to merge 1 commit into from
Closed

reexport hFlush #315

wants to merge 1 commit into from

Conversation

rektrex
Copy link
Collaborator

@rektrex rektrex commented Jul 10, 2020

Resolves #314

Checklist:

HLint

  • I've changed the exposed interface (add new reexports, remove reexports, rename reexported things, etc.).
    • I've updated hlint.dhall accordingly to my changes (add new rules for the new imports, remove old ones, when they are outdated, etc.).
    • I've generated the new .hlint.yaml file (see this instructions).

General

  • I've updated the CHANGELOG with the short description of my latest changes.
  • All new and existing tests pass.
  • I keep the code style used in the files I've changed (see style-guide for more details).
  • I've used the stylish-haskell file.
  • My change requires the documentation updates.
    • I've updated the documentation accordingly.
  • I've added the [ci skip] text to the docs-only related commit's name.

Copy link
Contributor

@hint-man hint-man bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no place for me here... I will choose the truth I like.

@chshersh
Copy link
Contributor

@rektrex Thanks for your PR! Meanwhile, we've discussed a slightly better module structure with @vrom911, and we were thinking about reexporting more stuff that works with Handle from a separate Relude.Lifted.Handle module. If you are interested in what needs to be done and pushing this forward, we can discuss it under the corresponding issue first 🙂 Otherwise, don't worry! We can close this PR and take care of this issue by ourselves.

@chshersh
Copy link
Contributor

Closing in favour of #323

@chshersh chshersh closed this Aug 21, 2020
@chshersh chshersh added the reexport Reexport something new label Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reexport Reexport something new
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reexport 'hFlush'
2 participants