Add lifted handle functions #323
Conversation
![hint-man[bot]](https://avatars.githubusercontent.com/in/20170?s=60&v=4){kind=small}
src/Relude/Lifted.hs
Outdated
| @@ -95,3 +98,6 @@ Lifted reexports from "Data.IORef" module. | |||
| {- $terminal | |||
| Lifted functions to work with stdin and stdout. | |||
| -} | |||
| {- $handle | |||
| Lifted functions to work with IO Handles. | |||
There was a problem hiding this comment.
| Lifted functions to work with IO Handles. | |
| Lifted functions to work with 'Relude.Base.IO' 'Handle's. |
src/Relude/Lifted/Handle.hs
Outdated
| , hIsEOF | ||
| , hSetBuffering | ||
| , hGetBuffering | ||
| , module System.IO |
There was a problem hiding this comment.
I would prefer to inline this export explicitly.
It is better for documentation and you can see straight away what is exported from this module without going into sources 🙂
src/Relude/Lifted/Handle.hs
Outdated
| Stability: Stable | ||
| Portability: Portable | ||
|
|
||
| Lifted functions to with IO Handles. |
There was a problem hiding this comment.
| Lifted functions to with IO Handles. | |
| Lifted functions to work with 'IO' 'Handle's. |
src/Relude/Lifted/Handle.hs
Outdated
| @since 0.8.0.0 | ||
| -} | ||
| hSetBuffering :: MonadIO m => IO.Handle -> IO.BufferMode -> m () | ||
| hSetBuffering = (liftIO .) . IO.hSetBuffering |
There was a problem hiding this comment.
I would prefer a less point-free implementation
| hSetBuffering = (liftIO .) . IO.hSetBuffering | |
| hSetBuffering h = liftIO . IO.hSetBuffering h |
|
Hi @rektrex! I've noticed that there are still a few documentation suggestions left unfixed. Would you like to apply them as well, so we can proceed with this PR? Looking forward to having these changes merged after everything is done 🙂 |
Co-authored-by: Veronika Romashkina <vrom911@gmail.com>
|
Sorry, forgot to add [ci skip]. |
|
@rektrex Sorry for the delay in merge. Stack on Travis didn't work around that time, so the CI was failing. I've rerun the Travis CI, and it passed! 💚 Thanks again for the PR 👍 |
Resolves #314
Checklist:
HLint
hlint.dhallaccordingly to my changes (add new rules for the new imports, remove old ones, when they are outdated, etc.)..hlint.yamlfile (see this instructions).General
stylish-haskellfile.[ci skip]text to the docs-only related commit's name.