Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHC 9.2.1 compatibility - Remove Option #387

Closed
wants to merge 5 commits into from
Closed

Conversation

sullyj3
Copy link
Contributor

@sullyj3 sullyj3 commented Oct 30, 2021

Also resolves #363

Blocked as of 2021-11-23 - tests are waiting on some dependencies to be able to build.

Checklist:

HLint

  • I've changed the exposed interface (add new reexports, remove reexports, rename reexported things, etc.).
    • I've updated hlint.dhall accordingly to my changes (add new rules for the new imports, remove old ones, when they are outdated, etc.).
    • I've generated the new .hlint.yaml file (see this instructions).

General

  • I've updated the CHANGELOG with the short description of my latest changes.
  • All new and existing tests pass.
  • I keep the code style used in the files I've changed (see style-guide for more details).
  • I've used the stylish-haskell file.
  • My change requires the documentation updates.
    • I've updated the documentation accordingly.
  • I've added the [ci skip] text to the docs-only related commit's name.

@sullyj3 sullyj3 changed the title GHC 9.2.1 compatibility GHC 9.2.1 compatibility - Remove Option Oct 30, 2021
@chshersh
Copy link
Contributor

chshersh commented Nov 5, 2021

I believe this should also resolve #388. But it'll require updating the GitHub Actions config to build with GHC 9.2. Otherwise, we can't test it. So we're currently blocked on the Haskell GitHub Actions to support the latest GHC.

@sullyj3
Copy link
Contributor Author

sullyj3 commented Nov 23, 2021

Supported as of haskell/actions/issues/55 :)

I think this is how other projects do it.
@sullyj3
Copy link
Contributor Author

sullyj3 commented Nov 23, 2021

awaiting hedgehogqa/haskell-hedgehog/pull/436

@njaremko
Copy link

njaremko commented Feb 7, 2022

@sullyj3 It seems this is fine to move forward?

@sullyj3
Copy link
Contributor Author

sullyj3 commented Feb 8, 2022

I'm not doing a whole lot of Haskell at the moment, feel free to take over if you like.

@dysinger
Copy link

fc6a503 wasn't merged yet. Still getting an error from master on GHC 9.2.2

@TeofilC TeofilC mentioned this pull request Mar 28, 2022
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Option
4 participants