-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ghc 9.2 compat #403
Ghc 9.2 compat #403
Conversation
Builds fine and all tests pass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, @TeofilC !
This looks great 👍🏼
@@ -104,7 +104,7 @@ source-repository head | |||
location: git@github.com:kowainik/relude.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also please add GHC-9.2 to the tested-with
above? 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, should be fixed by 23feee1
I think this is how other projects do it.
this is required to allow the doctests to run
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Awesome work @TeofilC 👏🏻 🔝
Resolves #363 and #388
Depends on #400 .
This is #387 resurrected.
I think I've managed to fix the doctest failures, and added a 9.2.2 job to CI.
The version of cabal-install had to be bumped on CI otherwise it imposes unsatisfiable constraints from the Cabal library.
Checklist:
HLint
hlint.dhall
accordingly to my changes (add new rules for the new imports, remove old ones, when they are outdated, etc.)..hlint.yaml
file (see this instructions).General
stylish-haskell
file.[ci skip]
text to the docs-only related commit's name.