Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ghc 9.2 compat #403

Merged
merged 12 commits into from
Apr 4, 2022
Merged

Ghc 9.2 compat #403

merged 12 commits into from
Apr 4, 2022

Conversation

TeofilC
Copy link
Contributor

@TeofilC TeofilC commented Mar 28, 2022

Resolves #363 and #388
Depends on #400 .

This is #387 resurrected.
I think I've managed to fix the doctest failures, and added a 9.2.2 job to CI.
The version of cabal-install had to be bumped on CI otherwise it imposes unsatisfiable constraints from the Cabal library.

Checklist:

HLint

  • I've changed the exposed interface (add new reexports, remove reexports, rename reexported things, etc.).
    • I've updated hlint.dhall accordingly to my changes (add new rules for the new imports, remove old ones, when they are outdated, etc.).
    • I've generated the new .hlint.yaml file (see this instructions).

General

  • I've updated the CHANGELOG with the short description of my latest changes.
  • All new and existing tests pass.
  • I keep the code style used in the files I've changed (see style-guide for more details).
  • I've used the stylish-haskell file.
  • My change requires the documentation updates.
    • I've updated the documentation accordingly.
  • I've added the [ci skip] text to the docs-only related commit's name.

Builds fine and all tests pass.
Copy link
Member

@vrom911 vrom911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, @TeofilC !
This looks great 👍🏼

@@ -104,7 +104,7 @@ source-repository head
location: git@github.com:kowainik/relude.git
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also please add GHC-9.2 to the tested-with above? 🙂

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, should be fixed by 23feee1

Copy link
Contributor

@chshersh chshersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Awesome work @TeofilC 👏🏻 🔝

@chshersh chshersh merged commit b2f43f4 into kowainik:main Apr 4, 2022
This was referenced Apr 4, 2022
@TeofilC TeofilC deleted the ghc-9.2-compat branch April 5, 2022 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Option
5 participants