Refactor pyo3 usage #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LilyFirefly
force-pushed
the
refactor-pyo3-usage
branch
from
3d9cadf to
f196892
Compare
LilyFirefly
force-pushed
the
refactor-pyo3-usage
branch
from
855819c to
e0e068d
Compare
seddonym
approved these changes
Aug 4, 2025
| with pytest.raises(ValueError) as exc_info: | ||
| fluent.Bundle("$", []) | ||
|
|
||
| assert str(exc_info.value) == "Invalid language: '$'" |
There was a problem hiding this comment.
🐼 Could do this using with pytest.raises(Value, match="..."):.
There was a problem hiding this comment.
I could, but I don't really like it because then I have to deal with regexes and escaping. This way it's an exact match.
|
|
||
| if let Some(variables) = variables { | ||
| for variable in variables { | ||
| for (python_key, python_value) in variables { |
| create_exception!(rustfluent, ParserError, pyo3::exceptions::PyException); | ||
|
|
||
| #[pymodule] | ||
| fn rustfluent(m: &Bound<'_, PyModule>) -> PyResult<()> { |
There was a problem hiding this comment.
Good shout, I much prefer the new syntax.
| } | ||
| } | ||
| } else if python_value.is_instance_of::<PyInt>() | ||
| && let Ok(int_value) = python_value.extract::<i32>() |
There was a problem hiding this comment.
I didn't know you could do this, cool!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #26.
.expectwith raising aValueErrorfor malformedlanguagetupleunpacking into theforloopFluentArgsby only doing the fallback in one placeerrorsVecnext to thebundle.format_patternthat uses it