Dev ergonomics #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, the tests and the debugger were awkward to run from Pycharm, due to how it added certain directories to the Python path automatically, and how it interacted with compiled Python extensions. This moves the tests up one level into a tests directory, which should simplify the developer experience and everything will just work.
It's useful to be able to run maturin develop when working in a mixed Python/Rust environment.
seddonym
force-pushed
the
dev-ergonomics
branch
5 times, most recently
from
d86417c to
53202e7
Compare
Prior to this, changes to the Rust code wouldn't get picked up when running the Python tests.
Although this is slightly more verbose, it gives us better opportunities for backward-compatibility if we choose to add new options to `get_translation` later. The name 'variables' is taken from the official Fluent docs https://projectfluent.org/fluent/guide/variables.html
seddonym
force-pushed
the
dev-ergonomics
branch
from
53202e7 to
7adf018
Compare
seddonym
force-pushed
the
dev-ergonomics
branch
from
7adf018 to
ded2332
Compare
dooferlad
approved these changes
Sep 23, 2024
| fn new(namespace: &str, ftl_filenames: &'_ Bound<'_, PyList>) -> PyResult<Self> { | ||
| let langid_en: LanguageIdentifier = namespace.parse().expect("Parsing failed"); | ||
| let mut bundle = FluentBundle::new_concurrent(vec![langid_en]); | ||
| fn new(language: &str, ftl_filenames: &'_ Bound<'_, PyList>) -> PyResult<Self> { |
There was a problem hiding this comment.
I think this should be locale (at least, that is what the docs use: https://docs.rs/fluent/latest/fluent/bundle/struct.FluentBundle.html#method.new).
There was a problem hiding this comment.
Hmm... it's a bit confusing.
The reason I called it language here is because I think we are expecting it to be a Unicode Language Identifier rather than a locale, but I do take your point that it isn't consistent with the function name. But have I got it wrong there? It feels weird to me to call it locale if it is meant to be a language identfier, if that is actually the case.
Merging for now but happy to continue to iterate...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweaks to improve the local dev experience, in particular around running tests and documentation.
I've also taken the opportunity to slightly change the function parameters.