Skip to content
This repository has been archived by the owner on Jan 25, 2020. It is now read-only.

Change bcrypt version for windows support #5

Merged
merged 1 commit into from
Mar 20, 2015

Conversation

josh-birk
Copy link
Contributor

No description provided.

@aredridel
Copy link
Contributor

LGTM!

aredridel added a commit that referenced this pull request Mar 20, 2015
Change bcrypt version for windows support
@aredridel aredridel merged commit 2a0a65f into krakenjs:master Mar 20, 2015
@josh-birk
Copy link
Contributor Author

Hi Aria,

Thanks for merging that so quickly. I have a quick question/concern. This
example code is actually included in two places:
1.https://github.com/krakenjs/kraken-example-with-passport
2.https://github.com/krakenjs/kraken-examples/tree/master/with.passport

So any changes should be made to both... Why was this setup like this? I
can make another pull request for the other repository if you want, but I
also want to make some changes to the readme to clear up some of that
confusion and also mention the need for visual studio for windows. I can
do a separate pull request for that.

Let me know what you would prefer.

Thanks,
Josh

On Thu, Mar 19, 2015 at 10:11 PM, Aria Stewart notifications@github.com
wrote:

Merged #5
#5.


Reply to this email directly or view it on GitHub
#5 (comment)
.

@aredridel
Copy link
Contributor

I need to kill off the merged repo and update some doc links. This is the canonical one now!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants