Bump webpack in lsp-ws-connection to pull new hashing algorithm.
#1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
krassowski
force-pushed
the
bump-webpack-in-ws-lsp-connection
branch
from
6c5edb5
to
0fbef6c
Compare
krassowski
force-pushed
the
bump-webpack-in-ws-lsp-connection
branch
from
0fbef6c
to
a6aeebc
Compare
Improve tooltips with refined `HoverBox` positioning in 3.4.7
krassowski
force-pushed
the
bump-webpack-in-ws-lsp-connection
branch
from
8934bb1
to
6324606
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean fix for binder builds failing.
Confusingly
vscode-ws-jsonrpccontains both client and server code; server is assumed to run on node, so requires some node-specific modules likenet,pathandcrypto; none of those are used for the client code (thelistenfunction that we use). With webpack 4 there were mocks and browser polyfills for those node modules but webpack 5 does not include them anymore. We could install them but those are not needed as we don't use the server code. JupyterLab itself makes similar choice of ignoringcryptobut it does polyfillpath).